Re: [Qemu-devel] [PATCH v2 12/14] qlit: improve QLit list vs qlist comparison

2017-08-31 Thread Marc-André Lureau
Hi - Original Message - > Markus Armbruster writes: > > > Marc-André Lureau writes: > > > >> Use QLIST_FOREACH_ENTRY() to simplify the code and break earlier. > >> > >> Check that the QLit list has the same size as the qlist, this should > >> ensure that we have an exact match when iter

Re: [Qemu-devel] [PATCH v2 12/14] qlit: improve QLit list vs qlist comparison

2017-08-31 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Use QLIST_FOREACH_ENTRY() to simplify the code and break earlier. >> >> Check that the QLit list has the same size as the qlist, this should >> ensure that we have an exact match when iterating over qlist for >> comparing the elements. >

Re: [Qemu-devel] [PATCH v2 12/14] qlit: improve QLit list vs qlist comparison

2017-08-30 Thread Markus Armbruster
Marc-André Lureau writes: > Use QLIST_FOREACH_ENTRY() to simplify the code and break earlier. > > Check that the QLit list has the same size as the qlist, this should > ensure that we have an exact match when iterating over qlist for > comparing the elements. > > Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v2 12/14] qlit: improve QLit list vs qlist comparison

2017-08-25 Thread Marc-André Lureau
Use QLIST_FOREACH_ENTRY() to simplify the code and break earlier. Check that the QLit list has the same size as the qlist, this should ensure that we have an exact match when iterating over qlist for comparing the elements. Signed-off-by: Marc-André Lureau --- qobject/qlit.c | 53 ++