Re: [Qemu-devel] [PATCH v2 11/54] quorum: use qapi_enum_parse() in quorum_open

2017-08-23 Thread Alberto Garcia
On Wed 23 Aug 2017 01:24:09 PM CEST, Markus Armbruster wrote: >> static int quorum_open(BlockDriverState *bs, QDict *options, int flags, >> Error **errp) >> { >> @@ -925,7 +908,13 @@ static int quorum_open(BlockDriverState *bs, QDict >> *options, int flags, >> go

Re: [Qemu-devel] [PATCH v2 11/54] quorum: use qapi_enum_parse() in quorum_open

2017-08-23 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > block/quorum.c | 27 --- > 1 file changed, 8 insertions(+), 19 deletions(-) > > diff --git a/block/quorum.c b/block/quorum.c > index d04da4f430..e4271caa7a 100644 > --- a/block/quorum.c > +++ b/block/qu

Re: [Qemu-devel] [PATCH v2 11/54] quorum: use qapi_enum_parse() in quorum_open

2017-08-23 Thread Markus Armbruster
Alberto Garcia writes: > On Tue 22 Aug 2017 03:22:12 PM CEST, Marc-André Lureau wrote: > >> @@ -925,7 +908,13 @@ static int quorum_open(BlockDriverState *bs, QDict >> *options, int flags, >> goto exit; >> } >> >> -ret = parse_read_pattern(qemu_opt_get(opts, QUORUM_OPT_READ_PA

Re: [Qemu-devel] [PATCH v2 11/54] quorum: use qapi_enum_parse() in quorum_open

2017-08-22 Thread Alberto Garcia
On Tue 22 Aug 2017 03:22:12 PM CEST, Marc-André Lureau wrote: > @@ -925,7 +908,13 @@ static int quorum_open(BlockDriverState *bs, QDict > *options, int flags, > goto exit; > } > > -ret = parse_read_pattern(qemu_opt_get(opts, QUORUM_OPT_READ_PATTERN)); > +if (!qemu_opt_get(

[Qemu-devel] [PATCH v2 11/54] quorum: use qapi_enum_parse() in quorum_open

2017-08-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- block/quorum.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index d04da4f430..e4271caa7a 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -22,6 +22,7 @@ #include "qapi/qmp/