Re: [Qemu-devel] [PATCH v2 11/22] target-cris: Mirror gen_opc_pc into insn_start

2015-09-22 Thread Aurelien Jarno
On 2015-09-17 21:55, Richard Henderson wrote: > This perhaps isn't ideal in terms of (ab)using the "pc" field > to encode both pc and ppc + delay branch state, as one has to > be aware of this when examining opcode dumps. > > But it preserves existing logic, which will be good for bisection, > and

[Qemu-devel] [PATCH v2 11/22] target-cris: Mirror gen_opc_pc into insn_start

2015-09-17 Thread Richard Henderson
This perhaps isn't ideal in terms of (ab)using the "pc" field to encode both pc and ppc + delay branch state, as one has to be aware of this when examining opcode dumps. But it preserves existing logic, which will be good for bisection, and it certainly does save storage space. Reviewed-by: Peter