Re: [Qemu-devel] [PATCH v2 11/20] target-mips: add MSA I5 format instruction

2014-10-29 Thread Leon Alrae
On 29/10/14 01:41, Yongbok Kim wrote: > +uint8_t df = (ctx->opcode >> 21) & 0x3; > +int64_t s5 = (ctx->opcode >> 16) & 0x1f; > +s5 = (s5 << 59) >> 59; /* sign extend s5 to 64 bits*/ Mixed declarations and code are not allowed. This issue occurs also in subsequent patches (12, 15, 17, 1

Re: [Qemu-devel] [PATCH v2 11/20] target-mips: add MSA I5 format instruction

2014-10-29 Thread James Hogan
Hi Yongbok, On Wed, Oct 29, 2014 at 01:41:59AM +, Yongbok Kim wrote: > +DEF_HELPER_5(msa_addvi_df, void, env, i32, i32, i32, s64) > +DEF_HELPER_5(msa_ceqi_df, void, env, i32, i32, i32, s64) > +DEF_HELPER_5(msa_clei_s_df, void, env, i32, i32, i32, s64) > +DEF_HELPER_5(msa_clei_u_df, void, env,

[Qemu-devel] [PATCH v2 11/20] target-mips: add MSA I5 format instruction

2014-10-28 Thread Yongbok Kim
add MSA I5 format instructions Signed-off-by: Yongbok Kim --- target-mips/helper.h | 13 target-mips/msa_helper.c | 142 ++ target-mips/translate.c | 79 + 3 files changed, 234 insertions(+), 0 deletions(-) diff