Re: [Qemu-devel] [PATCH v2 11/16] target/arm: Add SVE to migration state

2018-01-22 Thread Richard Henderson
On 01/22/2018 06:16 AM, Peter Maydell wrote: >> +/* The first two words of each Zreg is stored in VFP state. */ >> +static const VMStateDescription vmstate_zreg_hi_reg = { >> +.name = "cpu/sve/zreg_hi", >> +.version_id = 1, >> +.minimum_version_id = 1, >> +.fields = (VMStateField[]

Re: [Qemu-devel] [PATCH v2 11/16] target/arm: Add SVE to migration state

2018-01-22 Thread Richard Henderson
On 01/22/2018 05:40 AM, Alex Bennée wrote: >> +#ifdef TARGET_AARCH64 >> +/* The expression ARM_MAX_VQ - 2 is 0 for pure AArch32 build, >> + * and ARMPredicateReg is actively empty. This triggers errors >> + * in the expansion of the VMSTATE macros. >> + */ > > This makes me think that #ifdef-ing

Re: [Qemu-devel] [PATCH v2 11/16] target/arm: Add SVE to migration state

2018-01-22 Thread Peter Maydell
On 19 January 2018 at 04:54, Richard Henderson wrote: > Save the high parts of the Zregs and all of the Pregs. > The ZCR_ELx registers are migrated via the CP mechanism. > > Signed-off-by: Richard Henderson > --- > target/arm/machine.c | 53 >

Re: [Qemu-devel] [PATCH v2 11/16] target/arm: Add SVE to migration state

2018-01-22 Thread Alex Bennée
Richard Henderson writes: > Save the high parts of the Zregs and all of the Pregs. > The ZCR_ELx registers are migrated via the CP mechanism. > > Signed-off-by: Richard Henderson > --- > target/arm/machine.c | 53 > > 1 file changed, 53 ins

[Qemu-devel] [PATCH v2 11/16] target/arm: Add SVE to migration state

2018-01-18 Thread Richard Henderson
Save the high parts of the Zregs and all of the Pregs. The ZCR_ELx registers are migrated via the CP mechanism. Signed-off-by: Richard Henderson --- target/arm/machine.c | 53 1 file changed, 53 insertions(+) diff --git a/target/arm/machine.c