Re: [Qemu-devel] [PATCH v2 10/14] pci: allow 0 address for PCI IO regions

2013-12-12 Thread Michael S. Tsirkin
On Thu, Dec 05, 2013 at 11:33:48PM +, Peter Maydell wrote: > On 5 December 2013 22:33, Michael Roth wrote: > > Some kernels program a 0 address for io regions. PCI 3.0 spec > > sectio 6.2.5.1 doesn't seem to disallow this. > > Hmm. The last PCI spec I looked at said 0 wasn't a valid MMIO > ad

Re: [Qemu-devel] [PATCH v2 10/14] pci: allow 0 address for PCI IO regions

2013-12-10 Thread Peter Maydell
On 10 December 2013 21:42, Michael Roth wrote: > Quoting Peter Maydell (2013-12-05 17:33:48) >> And presumably whoever put that specific check for 0 into >> QEMU had a reason for it. >> >> On the other hand I can't now find whatever document it was >> that I was reading that claimed 0 wasn't valid

Re: [Qemu-devel] [PATCH v2 10/14] pci: allow 0 address for PCI IO regions

2013-12-10 Thread Michael Roth
Quoting Peter Maydell (2013-12-05 17:33:48) > On 5 December 2013 22:33, Michael Roth wrote: > > Some kernels program a 0 address for io regions. PCI 3.0 spec > > sectio 6.2.5.1 doesn't seem to disallow this. > > Hmm. The last PCI spec I looked at said 0 wasn't a valid MMIO > address, so the varia

Re: [Qemu-devel] [PATCH v2 10/14] pci: allow 0 address for PCI IO regions

2013-12-05 Thread Peter Maydell
On 5 December 2013 22:33, Michael Roth wrote: > Some kernels program a 0 address for io regions. PCI 3.0 spec > sectio 6.2.5.1 doesn't seem to disallow this. Hmm. The last PCI spec I looked at said 0 wasn't a valid MMIO address, so the variant of this patch I wrote a while back made it a per PCI

[Qemu-devel] [PATCH v2 10/14] pci: allow 0 address for PCI IO regions

2013-12-05 Thread Michael Roth
Some kernels program a 0 address for io regions. PCI 3.0 spec sectio 6.2.5.1 doesn't seem to disallow this. Signed-off-by: Michael Roth --- hw/pci/pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index f15bbb0..fe5729c 100644 --- a/hw/pci/p