Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-17 Thread Ladi Prosek
On Mon, Jul 17, 2017 at 10:58 AM, Daniel P. Berrange wrote: > On Mon, Jul 17, 2017 at 08:54:18AM +0200, Ladi Prosek wrote: >> On Fri, Jul 14, 2017 at 12:41 PM, Daniel P. Berrange >> wrote: >> > On Thu, Jul 13, 2017 at 02:32:06PM +0100, Stefan Hajnoczi wrote: >> >> On Thu, Jul 13, 2017 at 01:02:30

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-17 Thread Daniel P. Berrange
On Mon, Jul 17, 2017 at 08:54:18AM +0200, Ladi Prosek wrote: > On Fri, Jul 14, 2017 at 12:41 PM, Daniel P. Berrange > wrote: > > On Thu, Jul 13, 2017 at 02:32:06PM +0100, Stefan Hajnoczi wrote: > >> On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: > >> > +/* > >> > + * Print an error m

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-16 Thread Ladi Prosek
On Fri, Jul 14, 2017 at 12:41 PM, Daniel P. Berrange wrote: > On Thu, Jul 13, 2017 at 02:32:06PM +0100, Stefan Hajnoczi wrote: >> On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: >> > +/* >> > + * Print an error message to current monitor if we have one, else to >> > stderr. >> > + *

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-16 Thread Ladi Prosek
On Sat, Jul 15, 2017 at 7:50 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Thu, Jul 13, 2017 at 03:48:02PM +0200, Ladi Prosek wrote: >>> On Thu, Jul 13, 2017 at 3:32 PM, Stefan Hajnoczi >>> wrote: >>> > On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: >>> >> +/* >>>

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-14 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Jul 13, 2017 at 03:48:02PM +0200, Ladi Prosek wrote: >> On Thu, Jul 13, 2017 at 3:32 PM, Stefan Hajnoczi wrote: >> > On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: >> >> +/* >> >> + * Print an error message to current monitor if we have one, else t

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-14 Thread Daniel P. Berrange
On Thu, Jul 13, 2017 at 02:32:06PM +0100, Stefan Hajnoczi wrote: > On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: > > +/* > > + * Print an error message to current monitor if we have one, else to > > stderr. > > + * Format arguments like sprintf(). The resulting message should be a

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-14 Thread Stefan Hajnoczi
On Thu, Jul 13, 2017 at 03:48:02PM +0200, Ladi Prosek wrote: > On Thu, Jul 13, 2017 at 3:32 PM, Stefan Hajnoczi wrote: > > On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: > >> +/* > >> + * Print an error message to current monitor if we have one, else to > >> stderr. > >> + * Format

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-13 Thread Ladi Prosek
On Thu, Jul 13, 2017 at 3:32 PM, Stefan Hajnoczi wrote: > On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: >> +/* >> + * Print an error message to current monitor if we have one, else to stderr. >> + * Format arguments like sprintf(). The resulting message should be a >> + * single ph

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-13 Thread Stefan Hajnoczi
On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: > +/* > + * Print an error message to current monitor if we have one, else to stderr. > + * Format arguments like sprintf(). The resulting message should be a > + * single phrase, with no trailing punctuation. The no-LF version allows >

[Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-13 Thread Ladi Prosek
Callers of error_report may want to compose the error message out of multiple separate format strings. To save them from always having to combine their strings into one (a process that would likely involve memory allocation which is good to avoid on error paths), new "nolf" variants of error_report