Re: [Qemu-devel] [PATCH v2 1/6] qapi: Support features for structs

2019-05-24 Thread Eric Blake
On 5/24/19 8:20 AM, Markus Armbruster wrote: > "Support features for structs" accidentally fits the "Do stuff" > commit message anti-pattern. Suggest: > > qapi: Add feature flags to struct types > >> +# @features: names of features that are supported by this version and build >> and >> +#

Re: [Qemu-devel] [PATCH v2 1/6] qapi: Support features for structs

2019-05-24 Thread Markus Armbruster
"Support features for structs" accidentally fits the "Do stuff" commit message anti-pattern. Suggest: qapi: Add feature flags to struct types Kevin Wolf writes: > Sometimes, the behaviour of QEMU changes compatibly, but without a > change in the QMP syntax (usually by allowing values or op

[Qemu-devel] [PATCH v2 1/6] qapi: Support features for structs

2019-05-17 Thread Kevin Wolf
Sometimes, the behaviour of QEMU changes compatibly, but without a change in the QMP syntax (usually by allowing values or operations that previously resulted in an error). QMP clients may still need to know whether the extension is available. This allows to add a list of features to struct defini