Re: [Qemu-devel] [PATCH v2 1/6] block: vmdk - make ret variable usage clear

2015-01-22 Thread Stefan Hajnoczi
On Tue, Jan 20, 2015 at 12:31:28PM -0500, Jeff Cody wrote: > Keep the variable 'ret' something that is returned by the function it is > defined in. For the return value of 'sscanf', use a more meaningful > variable name. > > Signed-off-by: Jeff Cody > --- > block/vmdk.c | 14 -- > 1

Re: [Qemu-devel] [PATCH v2 1/6] block: vmdk - make ret variable usage clear

2015-01-20 Thread John Snow
On 01/20/2015 12:31 PM, Jeff Cody wrote: Keep the variable 'ret' something that is returned by the function it is defined in. For the return value of 'sscanf', use a more meaningful variable name. Signed-off-by: Jeff Cody --- block/vmdk.c | 14 -- 1 file changed, 8 insertions(

[Qemu-devel] [PATCH v2 1/6] block: vmdk - make ret variable usage clear

2015-01-20 Thread Jeff Cody
Keep the variable 'ret' something that is returned by the function it is defined in. For the return value of 'sscanf', use a more meaningful variable name. Signed-off-by: Jeff Cody --- block/vmdk.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b