Re: [Qemu-devel] [PATCH v2 1/5] bitops: Add ONES macro

2013-04-05 Thread Peter Maydell
On 5 April 2013 10:11, Peter Crosthwaite wrote: > But I thought about this more, and perhaps just ditch the ? anyway, > and rely on the shift by 64 ending up as 0. That's undefined behaviour, please don't. -- PMM

Re: [Qemu-devel] [PATCH v2 1/5] bitops: Add ONES macro

2013-04-05 Thread Peter Crosthwaite
Hi Peter, On Fri, Apr 5, 2013 at 6:53 PM, Peter Maydell wrote: > On 5 April 2013 09:43, Peter Crosthwaite wrote: >> Little macro that just gives you N ones (justified to LSB). >> >> Signed-off-by: Peter Crosthwaite >> --- >> >> include/qemu/bitops.h |2 ++ >> 1 files changed, 2 insertions(

[Qemu-devel] [PATCH v2 1/5] bitops: Add ONES macro

2013-04-05 Thread Peter Crosthwaite
Little macro that just gives you N ones (justified to LSB). Signed-off-by: Peter Crosthwaite --- include/qemu/bitops.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index affcc96..da47fc8 100644 --- a/include/qemu/bitops.

Re: [Qemu-devel] [PATCH v2 1/5] bitops: Add ONES macro

2013-04-05 Thread Peter Maydell
On 5 April 2013 09:43, Peter Crosthwaite wrote: > Little macro that just gives you N ones (justified to LSB). > > Signed-off-by: Peter Crosthwaite > --- > > include/qemu/bitops.h |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/qemu/bitops.h b/include/qemu/b