Re: [Qemu-devel] [PATCH v2 1/4] qemu-iotests: refine common.config

2015-11-18 Thread tu bo
Hi Max: On 11/19/2015 12:45 AM, Max Reitz wrote: On 04.11.2015 03:26, Bo Tu wrote: Replacing sed with awk, then it's easier to read. I think you meant "awk with sed". It's my fault. thanks :-) Replacing "[ ! -z "$default_alias_machine" ]" with "[[ $default_alias_machine ]]", then it's s

Re: [Qemu-devel] [PATCH v2 1/4] qemu-iotests: refine common.config

2015-11-18 Thread Max Reitz
On 04.11.2015 03:26, Bo Tu wrote: > Replacing sed with awk, then it's easier to read. I think you meant "awk with sed". > Replacing "[ ! -z "$default_alias_machine" ]" with > "[[ $default_alias_machine ]]", then it's slightly shorter. > > Suggested-By: Sascha Silbe > Reviewed-by: Sascha Silbe

[Qemu-devel] [PATCH v2 1/4] qemu-iotests: refine common.config

2015-11-03 Thread Bo Tu
Replacing sed with awk, then it's easier to read. Replacing "[ ! -z "$default_alias_machine" ]" with "[[ $default_alias_machine ]]", then it's slightly shorter. Suggested-By: Sascha Silbe Reviewed-by: Sascha Silbe Reviewed-by: Eric Blake Signed-off-by: Bo Tu --- tests/qemu-iotests/common.co