Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-26 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 26, 2014 2:53 PM > To: Gonglei (Arei) > Cc: Jan Vesely; QEMU > Subject: Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to > usb-hid initfn > > Hi, > > > > -stati

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-25 Thread Gerd Hoffmann
Hi, > > -static void usb_hid_initfn(USBDevice *dev, int kind) > > +static void usb_hid_initfn(USBDevice *dev, int kind, > > + const USBDesc *usb1, const USBDesc > > *usb2, > > + Error **errp) > > I don't think it is a good idea that adding usb

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-25 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to > usb-hid initfn > > v2: rebase > > Signed-off-by: Jan Vesely > --- > hw/usb/dev-hid.c | 38 ++ > 1 file changed, 18 insertions(+), 20 deletions(-) > &

[Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-25 Thread Jan Vesely
v2: rebase Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 467ec86..90746ed 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -566,9 +566,23