Re: [Qemu-devel] [PATCH v2 1/3] qemu.py: fix is_running()

2017-07-19 Thread Fam Zheng
On Wed, 07/19 18:31, Amador Pahim wrote: > Current implementation is broken. It does not really test if the child > process is running. > > The Popen.returncode will only be set after by a poll(), wait() or > communicate(). If the Popen fails to launch a VM, the Popen.returncode > will not turn to

Re: [Qemu-devel] [PATCH v2 1/3] qemu.py: fix is_running()

2017-07-19 Thread Eduardo Habkost
On Wed, Jul 19, 2017 at 03:34:47PM -0300, Eduardo Habkost wrote: > On Wed, Jul 19, 2017 at 06:31:06PM +0200, Amador Pahim wrote: > > Current implementation is broken. It does not really test if the child > > process is running. > > > > The Popen.returncode will only be set after by a poll(), wait(

Re: [Qemu-devel] [PATCH v2 1/3] qemu.py: fix is_running()

2017-07-19 Thread Eduardo Habkost
On Wed, Jul 19, 2017 at 06:31:06PM +0200, Amador Pahim wrote: > Current implementation is broken. It does not really test if the child > process is running. > > The Popen.returncode will only be set after by a poll(), wait() or > communicate(). If the Popen fails to launch a VM, the Popen.returnco

[Qemu-devel] [PATCH v2 1/3] qemu.py: fix is_running()

2017-07-19 Thread Amador Pahim
Current implementation is broken. It does not really test if the child process is running. The Popen.returncode will only be set after by a poll(), wait() or communicate(). If the Popen fails to launch a VM, the Popen.returncode will not turn to None by itself. Instead of using Popen.returncode,