Re: [Qemu-devel] [PATCH v2 1/3] fw_cfg: fix -boot bootsplash error checking

2018-12-11 Thread Philippe Mathieu-Daudé
On 11/21/18 6:10 AM, Li Qiang wrote: > fw_cfg_bootsplash() gets option parameter "splash-time" > with qemu_opt_get(), then converts it to an integer by hand. > It neglects to check that conversion for errors. This is > needlessly complicated and error-prone. But as "splash-time > not specified" is

[Qemu-devel] [PATCH v2 1/3] fw_cfg: fix -boot bootsplash error checking

2018-11-20 Thread Li Qiang
fw_cfg_bootsplash() gets option parameter "splash-time" with qemu_opt_get(), then converts it to an integer by hand. It neglects to check that conversion for errors. This is needlessly complicated and error-prone. But as "splash-time not specified" is not the same as "splash-time=T" for any T, we n