Re: [Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-30 Thread Stefan Hajnoczi
On Wed, Aug 30, 2017 at 3:57 PM, Ishani wrote: > - On Aug 30, 2017, at 9:51 AM, Fam Zheng f...@redhat.com wrote: > >> On Tue, 08/29 22:13, Ishani Chugh wrote: >>> +class BackupTool(object): >>> +"""BackupTool Class""" >>> +def __init__(self, config_file=os.path.expanduser('~') + >>> +

Re: [Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-30 Thread Ishani
- On Aug 30, 2017, at 9:51 AM, Fam Zheng f...@redhat.com wrote: > On Tue, 08/29 22:13, Ishani Chugh wrote: >> +class BackupTool(object): >> +"""BackupTool Class""" >> +def __init__(self, config_file=os.path.expanduser('~') + >> + '/.config/qemu/qemu-backup-config'): >

Re: [Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > +class BackupTool(object): > +"""BackupTool Class""" > +def __init__(self, config_file=os.path.expanduser('~') + > + '/.config/qemu/qemu-backup-config'): > +if "QEMU_BACKUP_CONFIG" in os.environ: > +self.config_f

Re: [Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-29 Thread Fam Zheng
On Tue, 08/29 22:13, Ishani Chugh wrote: > +def _restore(self, guest_name): > +""" > +Prints Steps to perform restore operation > +""" > +if guest_name not in self.config.sections(): > +print("Cannot find specified guest", file=sys.stderr) > +

[Qemu-devel] [PATCH v2 1/3] backup: QEMU Backup Tool

2017-08-29 Thread Ishani Chugh
qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The tool writes details of guest in a configuration file and the