Re: [Qemu-devel] [PATCH v2 1/2] vfio-pci: Introduce vfio_set_event_handler helper

2019-01-23 Thread Auger Eric
Hi Alex, On 1/23/19 5:00 PM, Alex Williamson wrote: > On Wed, 23 Jan 2019 16:28:50 +0100 > Auger Eric wrote: > >> Hi Alex, >> >> On 1/22/19 8:51 PM, Alex Williamson wrote: >>> On Thu, 17 Jan 2019 22:06:31 +0100 >>> Eric Auger wrote: >>> The code used to attach the eventfd handler for th

Re: [Qemu-devel] [PATCH v2 1/2] vfio-pci: Introduce vfio_set_event_handler helper

2019-01-23 Thread Alex Williamson
On Wed, 23 Jan 2019 16:28:50 +0100 Auger Eric wrote: > Hi Alex, > > On 1/22/19 8:51 PM, Alex Williamson wrote: > > On Thu, 17 Jan 2019 22:06:31 +0100 > > Eric Auger wrote: > > > >> The code used to attach the eventfd handler for the ERR and > >> REQ irq indices can be factorized into a helpe

Re: [Qemu-devel] [PATCH v2 1/2] vfio-pci: Introduce vfio_set_event_handler helper

2019-01-23 Thread Auger Eric
Hi Alex, On 1/22/19 8:51 PM, Alex Williamson wrote: > On Thu, 17 Jan 2019 22:06:31 +0100 > Eric Auger wrote: > >> The code used to attach the eventfd handler for the ERR and >> REQ irq indices can be factorized into a helper. In subsequent >> patches we will extend this helper to support other i

Re: [Qemu-devel] [PATCH v2 1/2] vfio-pci: Introduce vfio_set_event_handler helper

2019-01-22 Thread Alex Williamson
On Thu, 17 Jan 2019 22:06:31 +0100 Eric Auger wrote: > The code used to attach the eventfd handler for the ERR and > REQ irq indices can be factorized into a helper. In subsequent > patches we will extend this helper to support other irq indices. > > We test whether the notification is allowed o

[Qemu-devel] [PATCH v2 1/2] vfio-pci: Introduce vfio_set_event_handler helper

2019-01-17 Thread Eric Auger
The code used to attach the eventfd handler for the ERR and REQ irq indices can be factorized into a helper. In subsequent patches we will extend this helper to support other irq indices. We test whether the notification is allowed outside of the helper: respectively check vdev->pci_aer and VFIO_F