Re: [Qemu-devel] [PATCH v2 1/2] qapi: fix coding style in parameters list

2014-04-25 Thread Eric Blake
On 04/25/2014 01:56 AM, Amos Kong wrote: > The space before point is redundant. Would sound better as: A space after * when declaring a pointer type is redundant. > > Signed-off-by: Amos Kong > --- > scripts/qapi-visit.py | 20 ++-- > 1 file changed, 10 insertions(+), 10 delet

Re: [Qemu-devel] [PATCH v2 1/2] qapi: fix coding style in parameters list

2014-04-25 Thread Fam Zheng
On Fri, 04/25 15:56, Amos Kong wrote: > The space before point is redundant. s/point/pointer Fam > > Signed-off-by: Amos Kong > --- > scripts/qapi-visit.py | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/scripts/qapi-visit.py b/scripts/qapi-vis

[Qemu-devel] [PATCH v2 1/2] qapi: fix coding style in parameters list

2014-04-25 Thread Amos Kong
The space before point is redundant. Signed-off-by: Amos Kong --- scripts/qapi-visit.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 45ce3a9..8ffed3d 100644 --- a/scripts/qapi-visit.py +++ b/scripts