Re: [Qemu-devel] [PATCH v2 1/2] configure: Define target access alignment in configure

2019-07-23 Thread Aleksandar Markovic
Hello, Tony On Mon, Jul 22, 2019 at 5:27 AM wrote: > Move the define of target access alignment earlier from > target/foo/cpu.h to configure. > > It would be better if the commit message explained WHY the change is needed and HOW it is achieved - not WHAT the change is. Yours, Aleksandar > Si

Re: [Qemu-devel] [PATCH v2 1/2] configure: Define target access alignment in configure

2019-07-22 Thread Philippe Mathieu-Daudé
Hi Tony, On 7/22/19 5:27 AM, tony.ngu...@bt.com wrote: > Move the define of target access alignment earlier from > target/foo/cpu.h to configure. > You missed: Suggested-by: Richard Henderson > Signed-off-by: Tony Nguyen The single change from your v1 is: - target_bigendian=yes + target_

[Qemu-devel] [PATCH v2 1/2] configure: Define target access alignment in configure

2019-07-21 Thread tony.nguyen
Move the define of target access alignment earlier from target/foo/cpu.h to configure. Signed-off-by: Tony Nguyen --- configure | 10 +- include/exec/poison.h | 1 + include/qom/cpu.h | 2 +- target/alpha/cpu.h| 2 -- target/hppa/cpu.h | 1 - target/mips/cpu.h