Re: [Qemu-devel] [PATCH v2 1/1] virtio-blk: fix race on guest notifiers

2017-03-13 Thread Paolo Bonzini
On 13/03/2017 13:41, Halil Pasic wrote: > > > On 03/10/2017 10:08 PM, Halil Pasic wrote: >> >> >> On 03/10/2017 05:47 PM, Paolo Bonzini wrote: >>> >>> On 07/03/2017 14:16, Halil Pasic wrote: The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and 9ffe337c08 "virtio-blk:

Re: [Qemu-devel] [PATCH v2 1/1] virtio-blk: fix race on guest notifiers

2017-03-13 Thread Halil Pasic
On 03/10/2017 10:08 PM, Halil Pasic wrote: > > > On 03/10/2017 05:47 PM, Paolo Bonzini wrote: >> >> On 07/03/2017 14:16, Halil Pasic wrote: >>> The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and >>> 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" >>

Re: [Qemu-devel] [PATCH v2 1/1] virtio-blk: fix race on guest notifiers

2017-03-10 Thread Halil Pasic
On 03/10/2017 05:47 PM, Paolo Bonzini wrote: > > On 07/03/2017 14:16, Halil Pasic wrote: >> The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and >> 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" >> changed how notifications are done for virtio-blk sub

Re: [Qemu-devel] [PATCH v2 1/1] virtio-blk: fix race on guest notifiers

2017-03-10 Thread Paolo Bonzini
On 07/03/2017 14:16, Halil Pasic wrote: > The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and > 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" > changed how notifications are done for virtio-blk substantially. Due to a > race condition, interrupts are

[Qemu-devel] [PATCH v2 1/1] virtio-blk: fix race on guest notifiers

2017-03-07 Thread Halil Pasic
The commits 03de2f527 "virtio-blk: do not use vring in dataplane" and 9ffe337c08 "virtio-blk: always use dataplane path if ioeventfd is active" changed how notifications are done for virtio-blk substantially. Due to a race condition, interrupts are lost when irqfd behind the guest notifier is torn