Re: [Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-24 Thread Denis V. Lunev
On 02/24/2017 04:31 PM, Paolo Bonzini wrote: > > On 24/02/2017 15:46, Marc-André Lureau wrote: +if (ret < 0 && errno != EAGAIN) { +if (tcp_chr_read_poll(chr) <= 0) { +tcp_chr_disconnect(chr); +return len; >>> This change b

Re: [Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-24 Thread Marc-André Lureau
Hi On Fri, Feb 24, 2017 at 7:31 PM Paolo Bonzini wrote: > > > On 24/02/2017 15:46, Marc-André Lureau wrote: > > > >>> +if (ret < 0 && errno != EAGAIN) { > >>> +if (tcp_chr_read_poll(chr) <= 0) { > >>> +tcp_chr_disconnect(chr); > >>> +return len

Re: [Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-24 Thread Paolo Bonzini
On 24/02/2017 15:46, Marc-André Lureau wrote: > >>> +if (ret < 0 && errno != EAGAIN) { >>> +if (tcp_chr_read_poll(chr) <= 0) { >>> +tcp_chr_disconnect(chr); >>> +return len; >>> >> >> This change breaks a number of assumption in vhost-user code

Re: [Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-24 Thread Marc-André Lureau
Hi On Fri, Feb 24, 2017 at 5:42 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Thu, Feb 2, 2017 at 5:20 PM Denis V. Lunev wrote: > > > >> From: Anton Nefedov > >> > >> Socket backend read handler should normally perform a disconnect, > however > >> the read handle

Re: [Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-24 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Feb 2, 2017 at 5:20 PM Denis V. Lunev wrote: > >> From: Anton Nefedov >> >> Socket backend read handler should normally perform a disconnect, however >> the read handler may not get a chance to run if the frontend is not ready >> (qemu_chr_be_can_write

Re: [Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-24 Thread Marc-André Lureau
Hi On Thu, Feb 2, 2017 at 5:20 PM Denis V. Lunev wrote: > From: Anton Nefedov > > Socket backend read handler should normally perform a disconnect, however > the read handler may not get a chance to run if the frontend is not ready > (qemu_chr_be_can_write() == 0). > > This means that in virtio

Re: [Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-02 Thread Denis V. Lunev
On 02/02/2017 04:18 PM, Denis V. Lunev wrote: > From: Anton Nefedov > > Socket backend read handler should normally perform a disconnect, however > the read handler may not get a chance to run if the frontend is not ready > (qemu_chr_be_can_write() == 0). > > This means that in virtio-serial front

[Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-02 Thread Denis V. Lunev
From: Anton Nefedov Socket backend read handler should normally perform a disconnect, however the read handler may not get a chance to run if the frontend is not ready (qemu_chr_be_can_write() == 0). This means that in virtio-serial frontend case if - the host has disconnected (giving EPIPE on