Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-07 Thread Kevin Wolf
Am 06.09.2016 um 23:44 hat John Snow geschrieben: > On 09/05/2016 05:15 AM, Markus Armbruster wrote: > >John Snow writes: > >>(3) Just allow flushes to work on devices not visible to the guest, > >>which is what I've done here. Internal requests should work, Guest > >>requests should fail. > > > >

Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-06 Thread Markus Armbruster
John Snow writes: > On 09/05/2016 05:15 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 09/02/2016 01:44 AM, Markus Armbruster wrote: John Snow writes: > If a device still has an attached BDS because the medium has not yet > been removed, we will be unable to migra

Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-06 Thread John Snow
On 09/05/2016 05:15 AM, Markus Armbruster wrote: John Snow writes: On 09/02/2016 01:44 AM, Markus Armbruster wrote: John Snow writes: If a device still has an attached BDS because the medium has not yet been removed, we will be unable to migrate to a new host because blk_flush will retur

Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-05 Thread Markus Armbruster
John Snow writes: > On 09/02/2016 01:44 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> If a device still has an attached BDS because the medium has not yet >>> been removed, we will be unable to migrate to a new host because >>> blk_flush will return an error for that backend. >>> >>>

Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-02 Thread John Snow
On 09/02/2016 01:44 AM, Markus Armbruster wrote: John Snow writes: If a device still has an attached BDS because the medium has not yet been removed, we will be unable to migrate to a new host because blk_flush will return an error for that backend. Replace the call to blk_is_available to b

Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-01 Thread Markus Armbruster
John Snow writes: > If a device still has an attached BDS because the medium has not yet > been removed, we will be unable to migrate to a new host because > blk_flush will return an error for that backend. > > Replace the call to blk_is_available to blk_is_inserted to weaken > the check and allo

Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-01 Thread John Snow
On 09/01/2016 06:11 PM, Eric Blake wrote: Sounds slightly nicer if you stop short: s/ to work// I'm happy with this edit if a maintainer would like to make it.

Re: [Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-01 Thread Eric Blake
On 09/01/2016 04:56 PM, John Snow wrote: > If a device still has an attached BDS because the medium has not yet > been removed, we will be unable to migrate to a new host because > blk_flush will return an error for that backend. > > Replace the call to blk_is_available to blk_is_inserted to weake

[Qemu-devel] [PATCH v2 1/1] block-backend: allow flush on devices with open tray

2016-09-01 Thread John Snow
If a device still has an attached BDS because the medium has not yet been removed, we will be unable to migrate to a new host because blk_flush will return an error for that backend. Replace the call to blk_is_available to blk_is_inserted to weaken the check and allow flushes from the backend to w