Re: [Qemu-devel] [PATCH v2 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2016-11-28 Thread Hao QingFeng
在 2016-11-28 15:56, liujing 写道: Hi QingFeng, I just have a question that whether the marker->data need convert? I've no idea, just suddenly realized this question. nope, the data is type of char * for the compressed data stream, so no endian issue. thanks. Jing On 11/26/2016 01:46 PM, Q

Re: [Qemu-devel] [PATCH v2 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2016-11-27 Thread liujing
Hi QingFeng, I just have a question that whether the marker->data need convert? I've no idea, just suddenly realized this question. Jing On 11/26/2016 01:46 PM, QingFeng Hao wrote: The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image w

[Qemu-devel] [PATCH v2 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2016-11-25 Thread QingFeng Hao
The problem was triggered by qemu-iotests case 055. It failed when it was comparing the compressed vmdk image with original test.img. The cause is that buf_len in vmdk_write_extent wasn't converted to little-endian before it was stored to disk. But later vmdk_read_extent read it and converted it f