Re: [Qemu-devel] [PATCH v2 09/23] error: New error_prepend(), error_reportf_err()

2015-12-18 Thread Markus Armbruster
Eric Blake writes: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Instead of simply propagating an error verbatim, we sometimes want to >> add to its message, like this: >> >> frobnicate(arg, &err); >> error_setg(errp, "Can't frobnicate %s: %s", >> arg, error_get

Re: [Qemu-devel] [PATCH v2 09/23] error: New error_prepend(), error_reportf_err()

2015-12-17 Thread Eric Blake
On 12/17/2015 09:49 AM, Markus Armbruster wrote: > Instead of simply propagating an error verbatim, we sometimes want to > add to its message, like this: > > frobnicate(arg, &err); > error_setg(errp, "Can't frobnicate %s: %s", >arg, error_get_pretty(err)); Did you inte

[Qemu-devel] [PATCH v2 09/23] error: New error_prepend(), error_reportf_err()

2015-12-17 Thread Markus Armbruster
Instead of simply propagating an error verbatim, we sometimes want to add to its message, like this: frobnicate(arg, &err); error_setg(errp, "Can't frobnicate %s: %s", arg, error_get_pretty(err)); error_free(err); This is suboptimal, because it loses err's hint (i