Re: [Qemu-devel] [PATCH v2 09/16] block: raw image file reopen

2012-09-13 Thread Jeff Cody
On 09/13/2012 02:53 PM, Paolo Bonzini wrote: > Il 13/09/2012 19:02, Jeff Cody ha scritto: >> I kept the stubs for them for completeness, >> however (I can remove them if that causes heartburn for others). > > The point of making them optional is to avoid stubs, isn't it? ;) > > Paolo > Fair poi

Re: [Qemu-devel] [PATCH v2 09/16] block: raw image file reopen

2012-09-13 Thread Paolo Bonzini
Il 13/09/2012 19:02, Jeff Cody ha scritto: > I kept the stubs for them for completeness, > however (I can remove them if that causes heartburn for others). The point of making them optional is to avoid stubs, isn't it? ;) Paolo

Re: [Qemu-devel] [PATCH v2 09/16] block: raw image file reopen

2012-09-13 Thread Jeff Cody
On 09/13/2012 12:05 PM, Paolo Bonzini wrote: > Il 13/09/2012 17:49, Jeff Cody ha scritto: >> +/* We have nothing to do for raw reopen, stubs just return >> + * success */ >> +static int raw_reopen_prepare(BDRVReopenState *state, Error **errp) >> +{ >> +return 0; >> +} >> + >> +static void raw_r

[Qemu-devel] [PATCH v2 09/16] block: raw image file reopen

2012-09-13 Thread Jeff Cody
These are the stubs for the file reopen drivers for the raw format. There is currently nothing that needs to be done by the raw driver in reopen. Signed-off-by: Jeff Cody --- block/raw.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/raw.c b/block/raw.c index

Re: [Qemu-devel] [PATCH v2 09/16] block: raw image file reopen

2012-09-13 Thread Paolo Bonzini
Il 13/09/2012 17:49, Jeff Cody ha scritto: > +/* We have nothing to do for raw reopen, stubs just return > + * success */ > +static int raw_reopen_prepare(BDRVReopenState *state, Error **errp) > +{ > +return 0; > +} > + > +static void raw_reopen_commit(BDRVReopenState *state) > +{ > +return