Re: [Qemu-devel] [PATCH v2 09/11] monitor: Split out monitor/qmp.c

2019-06-13 Thread Kevin Wolf
Am 13.06.2019 um 07:38 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 12.06.2019 um 15:11 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > --- a/include/monitor/monitor.h > >> > +++ b/include/monitor/monitor.h > >> > @@ -21,6 +21,7 @@ bool monitor_cur_is_qmp(vo

Re: [Qemu-devel] [PATCH v2 09/11] monitor: Split out monitor/qmp.c

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.06.2019 um 15:11 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Move QMP infrastructure from monitor/misc.c to monitor/qmp.c. This is >> > code that can be shared for all targets, so compile it only once. >> >> Less code compiled per target, yay! >>

Re: [Qemu-devel] [PATCH v2 09/11] monitor: Split out monitor/qmp.c

2019-06-12 Thread Kevin Wolf
Am 12.06.2019 um 15:11 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Move QMP infrastructure from monitor/misc.c to monitor/qmp.c. This is > > code that can be shared for all targets, so compile it only once. > > Less code compiled per target, yay! > > > The amount of function a

Re: [Qemu-devel] [PATCH v2 09/11] monitor: Split out monitor/qmp.c

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > Move QMP infrastructure from monitor/misc.c to monitor/qmp.c. This is > code that can be shared for all targets, so compile it only once. Less code compiled per target, yay! > The amount of function and particularly extern variables in > monitor_int.h is probably a bit larg

[Qemu-devel] [PATCH v2 09/11] monitor: Split out monitor/qmp.c

2019-06-11 Thread Kevin Wolf
Move QMP infrastructure from monitor/misc.c to monitor/qmp.c. This is code that can be shared for all targets, so compile it only once. The amount of function and particularly extern variables in monitor_int.h is probably a bit larger than it needs to be, but this way no non-trivial code modificat