Re: [Qemu-devel] [PATCH v2 08/20] target-mips: add msa_helper.c

2014-11-05 Thread Richard Henderson
On 10/29/2014 02:41 AM, Yongbok Kim wrote: > +static inline void msa_move_v(wr_t *pwd, wr_t *pws) > +{ > +uint32_t i; > + > +for (i = 0; i < DF_ELEMENTS(DF_DOUBLE); i++) { > +pwd->d[i] = pws->d[i]; > +} > +} Why bother? This is "*pwd = *pws". r~

Re: [Qemu-devel] [PATCH v2 08/20] target-mips: add msa_helper.c

2014-10-29 Thread Leon Alrae
On 29/10/14 01:41, Yongbok Kim wrote: > add msa_helper.c > > Signed-off-by: Yongbok Kim > --- > target-mips/Makefile.objs |2 +- > target-mips/msa_helper.c | 49 > + > 2 files changed, 50 insertions(+), 1 deletions(-) > create mode 100644 targ

Re: [Qemu-devel] [PATCH v2 08/20] target-mips: add msa_helper.c

2014-10-29 Thread James Hogan
On Wed, Oct 29, 2014 at 01:41:56AM +, Yongbok Kim wrote: > add msa_helper.c > > Signed-off-by: Yongbok Kim Reviewed-by: James Hogan Cheers James > --- > target-mips/Makefile.objs |2 +- > target-mips/msa_helper.c | 49 > + > 2 files cha

[Qemu-devel] [PATCH v2 08/20] target-mips: add msa_helper.c

2014-10-28 Thread Yongbok Kim
add msa_helper.c Signed-off-by: Yongbok Kim --- target-mips/Makefile.objs |2 +- target-mips/msa_helper.c | 49 + 2 files changed, 50 insertions(+), 1 deletions(-) create mode 100644 target-mips/msa_helper.c diff --git a/target-mips/Makefile.o