Re: [Qemu-devel] [PATCH v2 08/16] io: add abstract QIOChannel classes

2015-10-21 Thread Eric Blake
On 10/21/2015 11:32 AM, Daniel P. Berrange wrote: > >>> +/** >>> + * qio_channel_seek: >>> + * @ioc: the channel object >>> + * @offset: the position to seek to, relative to @whence >>> + * @whence: one of the POSIX SEEK_* constants >> >> Including SEEK_HOLE/SEEK_DATA? > > Are those actually POS

Re: [Qemu-devel] [PATCH v2 08/16] io: add abstract QIOChannel classes

2015-10-21 Thread Daniel P. Berrange
On Tue, Oct 20, 2015 at 11:48:03AM -0600, Eric Blake wrote: > On 10/12/2015 05:15 AM, Daniel P. Berrange wrote: > > Start the new generic I/O channel framework by defining a > > QIOChannel abstract base class. This is designed to feel > > similar to GLib's GIOChannel, but with the addition of > > s

Re: [Qemu-devel] [PATCH v2 08/16] io: add abstract QIOChannel classes

2015-10-20 Thread Eric Blake
On 10/12/2015 05:15 AM, Daniel P. Berrange wrote: > Start the new generic I/O channel framework by defining a > QIOChannel abstract base class. This is designed to feel > similar to GLib's GIOChannel, but with the addition of > support for using iovecs, qemu error reporting, file > descriptor passi

[Qemu-devel] [PATCH v2 08/16] io: add abstract QIOChannel classes

2015-10-12 Thread Daniel P. Berrange
Start the new generic I/O channel framework by defining a QIOChannel abstract base class. This is designed to feel similar to GLib's GIOChannel, but with the addition of support for using iovecs, qemu error reporting, file descriptor passing, coroutine integration and use of the QOM framework for e