Re: [Qemu-devel] [PATCH v2 08/12] cpus: always call seqlock_write in cpu_update_icount

2018-09-26 Thread Emilio G. Cota
On Wed, Sep 26, 2018 at 10:23:25 +0200, Paolo Bonzini wrote: > On 24/09/2018 20:46, Emilio G. Cota wrote: > > Applying this on my local tree is deadlocking icount, since > > cpu_update_icount is called from cpu_get_icount_raw_locked: > > > > #6 cpu_update_icount (cpu=) at /data/src/qemu/cpus.c:25

Re: [Qemu-devel] [PATCH v2 08/12] cpus: always call seqlock_write in cpu_update_icount

2018-09-26 Thread Paolo Bonzini
On 24/09/2018 20:46, Emilio G. Cota wrote: > Applying this on my local tree is deadlocking icount, since > cpu_update_icount is called from cpu_get_icount_raw_locked: > > #6 cpu_update_icount (cpu=) at /data/src/qemu/cpus.c:257 > #7 0x55a6fbc7ae5c in cpu_get_icount_raw_locked () at > /data/

Re: [Qemu-devel] [PATCH v2 08/12] cpus: always call seqlock_write in cpu_update_icount

2018-09-24 Thread Emilio G. Cota
On Mon, Sep 10, 2018 at 19:27:48 -0400, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > cpus.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/cpus.c b/cpus.c > index ebc13bac2d..38dabb138d 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -250,16 +250,12 @@ void cpu_update_ico

Re: [Qemu-devel] [PATCH v2 08/12] cpus: always call seqlock_write in cpu_update_icount

2018-09-11 Thread Richard Henderson
On 09/10/2018 04:27 PM, Emilio G. Cota wrote: > > -#ifndef CONFIG_ATOMIC64 > seqlock_write_lock(&timers_state.vm_clock_seqlock, > &timers_state.vm_clock_lock); > -#endif > atomic_set__nocheck(&timers_state.qemu_icount, > timers_state.qemu

Re: [Qemu-devel] [PATCH v2 08/12] cpus: always call seqlock_write in cpu_update_icount

2018-09-11 Thread Paolo Bonzini
On 11/09/2018 14:53, Richard Henderson wrote: >> >> -#ifndef CONFIG_ATOMIC64 >> seqlock_write_lock(&timers_state.vm_clock_seqlock, >> &timers_state.vm_clock_lock); >> -#endif >> atomic_set__nocheck(&timers_state.qemu_icount, >> timers_sta

[Qemu-devel] [PATCH v2 08/12] cpus: always call seqlock_write in cpu_update_icount

2018-09-10 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- cpus.c | 4 1 file changed, 4 deletions(-) diff --git a/cpus.c b/cpus.c index ebc13bac2d..38dabb138d 100644 --- a/cpus.c +++ b/cpus.c @@ -250,16 +250,12 @@ void cpu_update_icount(CPUState *cpu) int64_t executed = cpu_get_icount_executed(cpu); cpu-