Re: [Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 13:39, Stefan Hajnoczi ha scritto: >> > + >> > +bdi->cluster_size = >> > +(s->logical_sector_size / BDRV_SECTOR_SIZE) * s->block_size; > I thought s->block_size is in bytes. Why multiply by the logical block > size in 512-byte sectors? My mistake. Paolo

Re: [Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info

2013-11-20 Thread Stefan Hajnoczi
On Tue, Nov 19, 2013 at 06:07:30PM +0100, Paolo Bonzini wrote: > +static int vhdx_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) > +{ > +BDRVVHDXState *s = bs->opaque; > + > +bdi->cluster_size = > +(s->logical_sector_size / BDRV_SECTOR_SIZE) * s->block_size; I thought s->bloc

[Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info

2013-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/vhdx.c | 11 +++ block/vpc.c | 14 ++ 2 files changed, 25 insertions(+) diff --git a/block/vhdx.c b/block/vhdx.c index 7d1af96..9ab2b39 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1043,6 +1043,16 @@ static void vhdx_block_translate