Re: [Qemu-devel] [PATCH v2 06/18] qga: process_event() simplification and leak fix

2018-07-23 Thread Michael Roth
Quoting Marc-André Lureau (2018-07-19 13:40:59) > json_parser_parse_err() may return something else than a QDict, in > which case we loose the object. Let's keep track of the original > object to avoid leaks. > > When an error occurs, "qdict" contains the response, but we still > check the "execut

[Qemu-devel] [PATCH v2 06/18] qga: process_event() simplification and leak fix

2018-07-19 Thread Marc-André Lureau
json_parser_parse_err() may return something else than a QDict, in which case we loose the object. Let's keep track of the original object to avoid leaks. When an error occurs, "qdict" contains the response, but we still check the "execute" key there. Untangle a bit this code, by having a clear er