Re: [Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms

2012-10-29 Thread Gerd Hoffmann
Hi, > There still has to be a way to share the Property[] array (currently > contains maxframes). Duplicating the properties array to all > definitions is verbose and fragile. If I want to add a new properties > to EHCI i need to put it in the props array of every subclass. serial > has this pro

Re: [Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms

2012-10-28 Thread Peter Crosthwaite
On Sat, Oct 27, 2012 at 10:32 AM, Peter Crosthwaite wrote: > On Fri, Oct 26, 2012 at 10:24 PM, Gerd Hoffmann wrote: >> Hi, >> >>> +typedef struct EHCItfState { >>> +union { >>> +PCIDevice pcidev; >>> +}; >>> +struct EHCIState ehci; >>> +} EHCIItfState; >> >> I still think we

Re: [Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms

2012-10-26 Thread Peter Crosthwaite
On Fri, Oct 26, 2012 at 10:24 PM, Gerd Hoffmann wrote: > Hi, > >> +typedef struct EHCItfState { >> +union { >> +PCIDevice pcidev; >> +}; >> +struct EHCIState ehci; >> +} EHCIItfState; > > I still think we should have EHCIPCIState here, then add a > EHCISysbusState variant for

Re: [Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms

2012-10-26 Thread Gerd Hoffmann
Hi, > +typedef struct EHCItfState { > +union { > +PCIDevice pcidev; > +}; > +struct EHCIState ehci; > +} EHCIItfState; I still think we should have EHCIPCIState here, then add a EHCISysbusState variant for sysbus. Everybody else does it this way (ohci, esp, serial, ...) and

[Qemu-devel] [PATCH v2 05/11] usb/ehci: seperate out PCIisms

2012-10-25 Thread Peter Crosthwaite
Seperate the PCI stuff from the EHCI components. Extracted the PCIDevice out into a new wrapper struct to make EHCIState non-PCI-specific. Seperated tho non PCI init component out into a seperate "common" init function. Signed-off-by: Peter Crosthwaite --- Changed from v1: renamed VMSD defintions