Re: [Qemu-devel] [PATCH v2 05/10] intel-iommu: introduce vtd_page_walk_info

2018-05-18 Thread Auger Eric
Hi Peter, On 05/18/2018 07:59 AM, Peter Xu wrote: > On Thu, May 17, 2018 at 04:32:58PM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 05/04/2018 05:08 AM, Peter Xu wrote: >>> During the recursive page walking of IOVA page tables, some stack >>> variables are constant variables and never changed dur

Re: [Qemu-devel] [PATCH v2 05/10] intel-iommu: introduce vtd_page_walk_info

2018-05-17 Thread Peter Xu
On Thu, May 17, 2018 at 04:32:58PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > During the recursive page walking of IOVA page tables, some stack > > variables are constant variables and never changed during the whole page > > walking procedure. Isolate the

Re: [Qemu-devel] [PATCH v2 05/10] intel-iommu: introduce vtd_page_walk_info

2018-05-17 Thread Auger Eric
Hi Peter, On 05/04/2018 05:08 AM, Peter Xu wrote: > During the recursive page walking of IOVA page tables, some stack > variables are constant variables and never changed during the whole page > walking procedure. Isolate them into a struct so that we don't need to > pass those contants down the

[Qemu-devel] [PATCH v2 05/10] intel-iommu: introduce vtd_page_walk_info

2018-05-03 Thread Peter Xu
During the recursive page walking of IOVA page tables, some stack variables are constant variables and never changed during the whole page walking procedure. Isolate them into a struct so that we don't need to pass those contants down the stack every time and multiple times. Signed-off-by: Peter