Re: [Qemu-devel] [PATCH v2 04/20] target-mips: add 16, 64 bit load and store

2014-10-29 Thread Leon Alrae
On 29/10/14 01:41, Yongbok Kim wrote: > > Signed-off-by: Yongbok Kim > --- > target-mips/op_helper.c |7 +++ > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c > index 7cbf4cf..e878442 100644 > --- a/target-mips/op_helpe

Re: [Qemu-devel] [PATCH v2 04/20] target-mips: add 16, 64 bit load and store

2014-10-29 Thread James Hogan
On Wed, Oct 29, 2014 at 01:41:52AM +, Yongbok Kim wrote: > > Signed-off-by: Yongbok Kim You seem to have lost the commit message compared to v1. Patch looks fine to me, but IMO it's worth squashing this into patch 18, since that's the only place they're used. Cheers James > --- > target-

[Qemu-devel] [PATCH v2 04/20] target-mips: add 16, 64 bit load and store

2014-10-28 Thread Yongbok Kim
Signed-off-by: Yongbok Kim --- target-mips/op_helper.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index 7cbf4cf..e878442 100644 --- a/target-mips/op_helper.c +++ b/target-mips/op_helper.c @@ -90,10 +90,10 @@ st