Re: [Qemu-devel] [PATCH v2 04/18] hw/nvram/fw_cfg: Add trace events

2019-03-08 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 3/8/19 10:57 AM, Laszlo Ersek wrote: > Hi Phil, > > On 03/08/19 02:32, Philippe Mathieu-Daudé wrote: >> Add fw_cfg_arch_key_name() to be able to resolve architecture >> specific keys. All architectures do have specific keys, thus >> implement this function. Architectures that don't

Re: [Qemu-devel] [PATCH v2 04/18] hw/nvram/fw_cfg: Add trace events

2019-03-08 Thread Laszlo Ersek
Hi Phil, On 03/08/19 02:32, Philippe Mathieu-Daudé wrote: > Add fw_cfg_arch_key_name() to be able to resolve architecture > specific keys. All architectures do have specific keys, thus > implement this function. Architectures that don't use the fw_cfg > device don't have to implement this function

[Qemu-devel] [PATCH v2 04/18] hw/nvram/fw_cfg: Add trace events

2019-03-07 Thread Philippe Mathieu-Daudé
Add fw_cfg_arch_key_name() to be able to resolve architecture specific keys. All architectures do have specific keys, thus implement this function. Architectures that don't use the fw_cfg device don't have to implement this function, however to ease the Makefile rules and satisfy the linking, we pr