Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > QMP command vm-snapshot-delete takes two parameters: name and id. They are > optional, but one of the name or id must be provided. If both are provided > they > will match only the snapshot with the same name and id. The command returns > Snap

Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-04-25 Thread Wenchao Xia
于 2013-4-25 20:21, Eric Blake 写道: On 04/25/2013 12:58 AM, Wenchao Xia wrote: +char buf[256]; I know this fixed-size buffer is just a copy-and-paste from other code that displays snapshot information, but I really hate it. On the other hand, I can tolerate if we have it as an intermed

Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-04-25 Thread Eric Blake
On 04/25/2013 12:58 AM, Wenchao Xia wrote: > >>> +char buf[256]; >> >> I know this fixed-size buffer is just a copy-and-paste from other code >> that displays snapshot information, but I really hate it. On the other >> hand, I can tolerate if we have it as an intermediate step between two

Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-04-24 Thread Wenchao Xia
+char buf[256]; I know this fixed-size buffer is just a copy-and-paste from other code that displays snapshot information, but I really hate it. On the other hand, I can tolerate if we have it as an intermediate step between two series that both land in the same release. If your serie

Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-04-24 Thread Eric Blake
On 04/24/2013 09:32 AM, Pavel Hrdina wrote: > QMP command vm-snapshot-delete takes two parameters: name and id. They are > optional, but one of the name or id must be provided. If both are provided > they > will match only the snapshot with the same name and id. The command returns > SnapshotInfo

[Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-04-24 Thread Pavel Hrdina
QMP command vm-snapshot-delete takes two parameters: name and id. They are optional, but one of the name or id must be provided. If both are provided they will match only the snapshot with the same name and id. The command returns SnapshotInfo only if the snapshot exists, otherwise it returns an er