Re: [Qemu-devel] [PATCH v2 04/10] nbd-server: refactor simple reply sending

2017-10-11 Thread Vladimir Sementsov-Ogievskiy
09.10.2017 22:18, Eric Blake wrote: [adding Dan for a qio question - search for your name below] On 10/09/2017 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: Get rid of calculating structure fields offsets by hand and set_cork, rename nbd_co_send_reply to nbd_co_send_simple_reply. Do not use NBD

Re: [Qemu-devel] [PATCH v2 04/10] nbd-server: refactor simple reply sending

2017-10-10 Thread Paolo Bonzini
On 10/10/2017 10:40, Daniel P. Berrange wrote: > The I/O channels code does not make guarantees wrt concurrent usage of > threads or coroutines. It is the callers responsibility to avoid any > concurrent usage for all APIs. With coroutines you are at least avoiding > the danger of corrupting memory

Re: [Qemu-devel] [PATCH v2 04/10] nbd-server: refactor simple reply sending

2017-10-10 Thread Daniel P. Berrange
On Mon, Oct 09, 2017 at 02:18:10PM -0500, Eric Blake wrote: > [adding Dan for a qio question - search for your name below] > > On 10/09/2017 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > > Get rid of calculating structure fields offsets by hand and set_cork, > > rename nbd_co_send_reply to nbd_c

Re: [Qemu-devel] [PATCH v2 04/10] nbd-server: refactor simple reply sending

2017-10-09 Thread Eric Blake
[adding Dan for a qio question - search for your name below] On 10/09/2017 12:27 PM, Vladimir Sementsov-Ogievskiy wrote: > Get rid of calculating structure fields offsets by hand and set_cork, > rename nbd_co_send_reply to nbd_co_send_simple_reply. Do not use > NBDReply which will be upgraded in f

[Qemu-devel] [PATCH v2 04/10] nbd-server: refactor simple reply sending

2017-10-09 Thread Vladimir Sementsov-Ogievskiy
Get rid of calculating structure fields offsets by hand and set_cork, rename nbd_co_send_reply to nbd_co_send_simple_reply. Do not use NBDReply which will be upgraded in future patches to handle both simple and structured replies and will be used only in the client. Signed-off-by: Vladimir Sements