Re: [Qemu-devel] [PATCH v2 04/10] intel-iommu: only do page walk for MAP notifiers

2018-05-18 Thread Peter Xu
On Fri, May 18, 2018 at 09:38:07AM +0200, Auger Eric wrote: > Hi Peter, > > On 05/18/2018 07:53 AM, Peter Xu wrote: > > On Thu, May 17, 2018 at 03:39:50PM +0200, Auger Eric wrote: > >> Hi Peter, > >> > >> On 05/04/2018 05:08 AM, Peter Xu wrote: > >>> For UNMAP-only IOMMU notifiers, we don't really

Re: [Qemu-devel] [PATCH v2 04/10] intel-iommu: only do page walk for MAP notifiers

2018-05-18 Thread Auger Eric
Hi Peter, On 05/18/2018 07:53 AM, Peter Xu wrote: > On Thu, May 17, 2018 at 03:39:50PM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 05/04/2018 05:08 AM, Peter Xu wrote: >>> For UNMAP-only IOMMU notifiers, we don't really need to walk the page >> s/really// ;-) > > Ok. > >>> tables. Fasten tha

Re: [Qemu-devel] [PATCH v2 04/10] intel-iommu: only do page walk for MAP notifiers

2018-05-17 Thread Peter Xu
On Thu, May 17, 2018 at 03:39:50PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > For UNMAP-only IOMMU notifiers, we don't really need to walk the page > s/really// ;-) Ok. > > tables. Fasten that procedure by skipping the page table walk. That > > should

Re: [Qemu-devel] [PATCH v2 04/10] intel-iommu: only do page walk for MAP notifiers

2018-05-17 Thread Auger Eric
Hi Peter, On 05/04/2018 05:08 AM, Peter Xu wrote: > For UNMAP-only IOMMU notifiers, we don't really need to walk the page s/really// ;-) > tables. Fasten that procedure by skipping the page table walk. That > should boost performance for UNMAP-only notifiers like vhost. > > Signed-off-by: Peter

[Qemu-devel] [PATCH v2 04/10] intel-iommu: only do page walk for MAP notifiers

2018-05-03 Thread Peter Xu
For UNMAP-only IOMMU notifiers, we don't really need to walk the page tables. Fasten that procedure by skipping the page table walk. That should boost performance for UNMAP-only notifiers like vhost. Signed-off-by: Peter Xu --- include/hw/i386/intel_iommu.h | 2 ++ hw/i386/intel_iommu.c