On 08/26/2015 09:31 AM, Eduardo Habkost wrote:
> As long as somebody who understands QAPI says the changes make sense and
> should work, I am OK with them if the following is changed:
That would be me, right? See my other mail for my tentative R-b;
although if you start renaming things due to this
On 08/21/2015 09:36 AM, Kővágó, Zoltán wrote:
> Signed-off-by: Kővágó, Zoltán
The subject line is a one-line "what", and the commit body should be the
"why" - all but the most trivial "what" deserve a non-empty commit body.
In particular, I think you NEED to mention in the commit body that the
c
On Sat, Aug 22, 2015 at 05:56:40PM +0200, Kővágó Zoltán wrote:
> 2015-08-22 01:13 keltezéssel, Eduardo Habkost írta:
> >On Fri, Aug 21, 2015 at 05:36:59PM +0200, Kővágó, Zoltán wrote:
> >>Signed-off-by: Kővágó, Zoltán
> >
> >I don't understand QAPI enough to understand why exactly this is needed
>
2015-08-22 01:13 keltezéssel, Eduardo Habkost írta:
On Fri, Aug 21, 2015 at 05:36:59PM +0200, Kővágó, Zoltán wrote:
Signed-off-by: Kővágó, Zoltán
I don't understand QAPI enough to understand why exactly this is needed
(so I would like to get feedback from somebody who actually understands
QAP
On Fri, Aug 21, 2015 at 05:36:59PM +0200, Kővágó, Zoltán wrote:
> Signed-off-by: Kővágó, Zoltán
I don't understand QAPI enough to understand why exactly this is needed
(so I would like to get feedback from somebody who actually understands
QAPI unions), but I have one comment below.
[...]
> ##
Signed-off-by: Kővágó, Zoltán
---
numa.c | 2 +-
qapi-schema.json | 47 ---
2 files changed, 37 insertions(+), 12 deletions(-)
diff --git a/numa.c b/numa.c
index 402804b..376f990 100644
--- a/numa.c
+++ b/numa.c
@@ -227,7 +227,7 @@ static in
