Re: [Qemu-devel] [PATCH v2 03/26] armv7m: Explicit error for bad vector table

2015-12-28 Thread Peter Maydell
On 27 December 2015 at 20:43, Michael Davidsaver wrote: > On 12/17/2015 08:25 AM, Peter Maydell wrote: >> On 3 December 2015 at 00:18, Michael Davidsaver >> wrote: >>> ... >>> +static >>> +uint32_t arm_v7m_load_vector(ARMCPU *cpu) >>> + >>> +{ >>> +CPUState *cs = &cpu->parent_obj; >> This is

Re: [Qemu-devel] [PATCH v2 03/26] armv7m: Explicit error for bad vector table

2015-12-27 Thread Michael Davidsaver
On 12/17/2015 08:25 AM, Peter Maydell wrote: > On 3 December 2015 at 00:18, Michael Davidsaver wrote: >> ... >> +static >> +uint32_t arm_v7m_load_vector(ARMCPU *cpu) >> + >> +{ >> +CPUState *cs = &cpu->parent_obj; > This isn't the right way to cast to the base class of a QOM object. > You want

Re: [Qemu-devel] [PATCH v2 03/26] armv7m: Explicit error for bad vector table

2015-12-17 Thread Peter Maydell
On 3 December 2015 at 00:18, Michael Davidsaver wrote: > Give an explicit error and abort when a load > from VECBASE fails. Otherwise would likely > jump to 0, which for v7-m holds the reset stack > pointer address. > --- > target-arm/helper.c | 21 - > 1 file changed, 20 ins

[Qemu-devel] [PATCH v2 03/26] armv7m: Explicit error for bad vector table

2015-12-02 Thread Michael Davidsaver
Give an explicit error and abort when a load from VECBASE fails. Otherwise would likely jump to 0, which for v7-m holds the reset stack pointer address. --- target-arm/helper.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-a