Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-25 Thread Paolo Bonzini
Il 14/06/2013 12:09, Alexey Kardashevskiy ha scritto: > Hi. > > Ok. Back to the bug with this patch. The initial problem with this patch is > that "make check" fails. > > Please help with subpages. > > It turned out that tests use MALLOC_PERTURB_ which is normally off. Who > does not know - this

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-14 Thread Alexey Kardashevskiy
On 06/14/2013 11:56 PM, Paolo Bonzini wrote: > Il 14/06/2013 06:09, Alexey Kardashevskiy ha scritto: >> And - crash: >> >> >> #0 object_unref (obj=0xa7a7a7a7a7a7a7a7) at >> /home/alexey/pcipassthru/qemu-impreza/qom/object.c:691 > > Dangling pointer. One ref, two unrefs probably. No, subpages (a

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 06:09, Alexey Kardashevskiy ha scritto: > And - crash: > > > #0 object_unref (obj=0xa7a7a7a7a7a7a7a7) at > /home/alexey/pcipassthru/qemu-impreza/qom/object.c:691 Dangling pointer. One ref, two unrefs probably. I'm redoing the series according to Peter's request, it could fix it

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-14 Thread Alexey Kardashevskiy
Hi. Ok. Back to the bug with this patch. The initial problem with this patch is that "make check" fails. Please help with subpages. It turned out that tests use MALLOC_PERTURB_ which is normally off. Who does not know - this is a way to tell glibc to fill released memory with some value and then

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-13 Thread Alexey Kardashevskiy
Fails on qtest_init() in tests/libqtest.c, "Broken pipe". I cannot easily see what is wrong here with this patch but it is 100% reproducible on x86_64 :( On 06/13/2013 04:28 PM, Alexey Kardashevskiy wrote: > Hi! > > I do not know how (yet) but this patch breaks qtest on x86 (I bisected it): >

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-12 Thread Alexey Kardashevskiy
Hi! I do not know how (yet) but this patch breaks qtest on x86 (I bisected it): make check-qtest V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick tests/fdc-test tests/ide-test tests/hd-geo-test tests/r

[Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-04 Thread Paolo Bonzini
Add ref/unref calls at the following places: - places where memory regions are stashed by a listener and used outside the BQL (including in Xen or KVM). - memory_region_find callsites - creation of aliases and containers (only the aliased/contained region gets a reference to avoid loops) -