Re: [Qemu-devel] [PATCH v2 03/16] job: Add error message for failing jobs

2018-05-30 Thread Max Reitz
On 2018-05-29 22:38, Kevin Wolf wrote: > So far we relied on job->ret and strerror() to produce an error message > for failed jobs. Not surprisingly, this tends to result in completely > useless messages. > > This adds a Job.error field that can contain an error string for a > failing job, and a p

Re: [Qemu-devel] [PATCH v2 03/16] job: Add error message for failing jobs

2018-05-29 Thread Jeff Cody
On Tue, May 29, 2018 at 10:38:57PM +0200, Kevin Wolf wrote: > So far we relied on job->ret and strerror() to produce an error message > for failed jobs. Not surprisingly, this tends to result in completely > useless messages. > > This adds a Job.error field that can contain an error string for a >

[Qemu-devel] [PATCH v2 03/16] job: Add error message for failing jobs

2018-05-29 Thread Kevin Wolf
So far we relied on job->ret and strerror() to produce an error message for failed jobs. Not surprisingly, this tends to result in completely useless messages. This adds a Job.error field that can contain an error string for a failing job, and a parameter to job_completed() that sets the field. As