Re: [Qemu-devel] [PATCH v2 03/11] monitor: Make MonitorQMP a child class of Monitor

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.06.2019 um 09:59 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Currently, struct Monitor mixes state that is only relevant for HMP, >> > state that is only relevant for QMP, and some actually shared state. >> > In particular, a MonitorQMP field is p

Re: [Qemu-devel] [PATCH v2 03/11] monitor: Make MonitorQMP a child class of Monitor

2019-06-12 Thread Kevin Wolf
Am 12.06.2019 um 09:59 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Currently, struct Monitor mixes state that is only relevant for HMP, > > state that is only relevant for QMP, and some actually shared state. > > In particular, a MonitorQMP field is present in the state of any >

Re: [Qemu-devel] [PATCH v2 03/11] monitor: Make MonitorQMP a child class of Monitor

2019-06-12 Thread Markus Armbruster
Kevin Wolf writes: > Currently, struct Monitor mixes state that is only relevant for HMP, > state that is only relevant for QMP, and some actually shared state. > In particular, a MonitorQMP field is present in the state of any > monitor, even if it's not a QMP monitor and therefore doesn't use t

[Qemu-devel] [PATCH v2 03/11] monitor: Make MonitorQMP a child class of Monitor

2019-06-11 Thread Kevin Wolf
Currently, struct Monitor mixes state that is only relevant for HMP, state that is only relevant for QMP, and some actually shared state. In particular, a MonitorQMP field is present in the state of any monitor, even if it's not a QMP monitor and therefore doesn't use the state. As a first step to