Re: [Qemu-devel] [PATCH v2 01/13] block: Make essential BlockDriver objects public

2014-12-02 Thread Eric Blake
On 12/02/2014 02:11 AM, Max Reitz wrote: >>> -static BlockDriver bdrv_qcow2 = { >>> +BlockDriver *bdrv_qcow2 = &(BlockDriver){ >> Do we want any use of 'const', to avoid accidental manipulation of the >> pointer and/or pointed-to contents? > > Sounds good at first, but for instance qemu_opts_cr

Re: [Qemu-devel] [PATCH v2 01/13] block: Make essential BlockDriver objects public

2014-12-02 Thread Kevin Wolf
Am 27.11.2014 um 15:48 hat Max Reitz geschrieben: > There are some block drivers which are essential to QEMU and may not be > removed: These are raw, file and qcow2 (as the default non-raw format). > Make their BlockDriver objects public so they can be directly referenced > throughout the block lay

Re: [Qemu-devel] [PATCH v2 01/13] block: Make essential BlockDriver objects public

2014-12-02 Thread Max Reitz
On 2014-12-01 at 16:59, Eric Blake wrote: On 11/27/2014 07:48 AM, Max Reitz wrote: There are some block drivers which are essential to QEMU and may not be removed: These are raw, file and qcow2 (as the default non-raw format). Make their BlockDriver objects public so they can be directly referen

Re: [Qemu-devel] [PATCH v2 01/13] block: Make essential BlockDriver objects public

2014-12-01 Thread Eric Blake
On 11/27/2014 07:48 AM, Max Reitz wrote: > There are some block drivers which are essential to QEMU and may not be > removed: These are raw, file and qcow2 (as the default non-raw format). > Make their BlockDriver objects public so they can be directly referenced > throughout the block layer withou

[Qemu-devel] [PATCH v2 01/13] block: Make essential BlockDriver objects public

2014-11-27 Thread Max Reitz
There are some block drivers which are essential to QEMU and may not be removed: These are raw, file and qcow2 (as the default non-raw format). Make their BlockDriver objects public so they can be directly referenced throughout the block layer without needing to call bdrv_find_format() and having t