Re: [Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-14 Thread Stefan Hajnoczi
On Wed, Jan 07, 2015 at 03:19:13PM +0100, Peter Wu wrote: > On Wednesday 07 January 2015 13:19:34 Stefan Hajnoczi wrote: > > On Tue, Jan 06, 2015 at 06:48:04PM +0100, Peter Wu wrote: > > > DMG files have a variable length with a UDIF trailer at the end of a > > > file. This UDIF trailer is essentia

Re: [Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-07 Thread Peter Wu
On Wednesday 07 January 2015 13:19:34 Stefan Hajnoczi wrote: > On Tue, Jan 06, 2015 at 06:48:04PM +0100, Peter Wu wrote: > > DMG files have a variable length with a UDIF trailer at the end of a > > file. This UDIF trailer is essential as it describes the contents of > > the image. At the moment how

Re: [Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-07 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 06:48:04PM +0100, Peter Wu wrote: > DMG files have a variable length with a UDIF trailer at the end of a > file. This UDIF trailer is essential as it describes the contents of > the image. At the moment however, the start of this trailer is almost > always incorrect as bdrv_

[Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-06 Thread Peter Wu
DMG files have a variable length with a UDIF trailer at the end of a file. This UDIF trailer is essential as it describes the contents of the image. At the moment however, the start of this trailer is almost always incorrect as bdrv_getlength() returns a multiple of the block size (rounded up). Thi