Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 01:55:43PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 12:49, Michael S. Tsirkin ha scritto: > > The idea to sort devices by function makes sense to be. > > But ISA and PCI here are wrong, they try to sort > > things by connection. > > Almost all ISA and PCI devices are in

Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 12:49, Michael S. Tsirkin ha scritto: > The idea to sort devices by function makes sense to be. > But ISA and PCI here are wrong, they try to sort > things by connection. Almost all ISA and PCI devices are in their logical places. You could find the outliers immediately because they

Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-02 Thread Stefano Stabellini
On Tue, 2 Apr 2013, Paolo Bonzini wrote: > Il 02/04/2013 19:46, Stefano Stabellini ha scritto: > > This is what I get with the new branch: > > > > In file included from tpm/tpm_int.h:16, > > from tpm/tpm.c:19: > > ./tpm/tpm_tis.h:41: error: redefinition of typedef ‘TPMSizedBuffer’

Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-02 Thread Paolo Bonzini
Il 02/04/2013 19:46, Stefano Stabellini ha scritto: > This is what I get with the new branch: > > In file included from tpm/tpm_int.h:16, > from tpm/tpm.c:19: > ./tpm/tpm_tis.h:41: error: redefinition of typedef ‘TPMSizedBuffer’ > /local/scratch/sstabellini/qemu/include/tpm/tpm.h:

Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-02 Thread Stefano Stabellini
On Tue, 2 Apr 2013, Paolo Bonzini wrote: > Il 02/04/2013 19:01, Stefano Stabellini ha scritto: > > On Tue, 2 Apr 2013, Paolo Bonzini wrote: > >> This is part 2 of the reorganization. Following the discussion > >> of March 18 between me and Peter, the ARM CPU cores are in hw/cpu > >> (the i386 ICC

Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-02 Thread Paolo Bonzini
Il 02/04/2013 19:01, Stefano Stabellini ha scritto: > On Tue, 2 Apr 2013, Paolo Bonzini wrote: >> This is part 2 of the reorganization. Following the discussion >> of March 18 between me and Peter, the ARM CPU cores are in hw/cpu >> (the i386 ICC device will also go there). >> >> The following cha

Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-02 Thread Stefano Stabellini
On Tue, 2 Apr 2013, Paolo Bonzini wrote: > This is part 2 of the reorganization. Following the discussion > of March 18 between me and Peter, the ARM CPU cores are in hw/cpu > (the i386 ICC device will also go there). > > The following changes since commit 5d45de9796539f95eb6b1201588362981f8cb2d4