Re: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements

2018-06-21 Thread Richard Henderson
On 06/21/2018 01:00 AM, Stafford Horne wrote: > Thanks for these, I think there are a few white space issues throughout. Do > you > mind if I take these and clean them up (indent with space) and work on the DSX > and Interrupt issue I mentioned earlier? > > I can submit all during the next merge

Re: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements

2018-06-21 Thread Stafford Horne
On Mon, Jun 18, 2018 at 08:40:24AM -1000, Richard Henderson wrote: > This is almost a grab-bag of little improvements to the port. > > patches 1-3: > Fix singlestepping for gdbstub. This has apparently never > worked, as the first commit has the same bug of not advancing > the pc when stepp

Re: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements

2018-06-18 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180618184046.6270-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH v2 00/22] target/openrisc improvements

2018-06-18 Thread Richard Henderson
This is almost a grab-bag of little improvements to the port. patches 1-3: Fix singlestepping for gdbstub. This has apparently never worked, as the first commit has the same bug of not advancing the pc when stepping. patches 4: Link more TBs. patches 5-6: Exit the TB after l.mtspr ins