Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups

2015-05-29 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 26 May 2015 17:20:35 +0200 > Markus Armbruster wrote: > >> Command handlers still use QError. Left for another day. > > Great work! I've found one bug that has to be addressed before merging. > Also, for the error conversions you're doing you're going from > qe

Re: [Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups

2015-05-28 Thread Luiz Capitulino
On Tue, 26 May 2015 17:20:35 +0200 Markus Armbruster wrote: > Command handlers still use QError. Left for another day. Great work! I've found one bug that has to be addressed before merging. Also, for the error conversions you're doing you're going from qerror_report() to error_set() but I'd re

[Qemu-devel] [PATCH v2 00/20] monitor: Wean core off QError, and other cleanups

2015-05-26 Thread Markus Armbruster
Command handlers still use QError. Left for another day. v2: * Trivially rebased * PATCH 01: Drop another async remnant [Eric] * PATCH 01+02+18: Improve commit messages * PATCH 03+04: client_migrate_info still hasn't been implemented VNC, de-document [Eric, Gerd] * PATCH 16+19: Don't inline mon