Re: [Qemu-devel] [PATCH v2 00/13] blockjob: refactor mirror_throttle

2018-01-30 Thread John Snow
ping; I won't respin for patchew until this gets looked over again, sorry :) On 01/19/2018 03:58 PM, John Snow wrote: > mirror_throttle attempts to make sure we yield every so often when we're > doing operations that may not otherwise be as cooperative as we'd like. > > This pattern is useful to

Re: [Qemu-devel] [PATCH v2 00/13] blockjob: refactor mirror_throttle

2018-01-19 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180119205847.7141-1-js...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/13] blockjob: refactor mirror_throttle === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

[Qemu-devel] [PATCH v2 00/13] blockjob: refactor mirror_throttle

2018-01-19 Thread John Snow
mirror_throttle attempts to make sure we yield every so often when we're doing operations that may not otherwise be as cooperative as we'd like. This pattern is useful to other jobs like commit as well; if commit continuously decides not to copy data (and calculates delay_ns to be 0), we'll freque