Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

2013-12-19 Thread Stefan Hajnoczi
On Wed, Dec 18, 2013 at 06:05:39PM +0100, Markus Armbruster wrote: > Andreas Färber writes: > > > I had a brief look at this series. Dropping redundant fields certainly > > sounds good and after the lengthy QOM'ifications of IDE devices we seem > > to no longer break any devices, but whether to c

Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

2013-12-18 Thread Markus Armbruster
Andreas Färber writes: > I had a brief look at this series. Dropping redundant fields certainly > sounds good and after the lengthy QOM'ifications of IDE devices we seem > to no longer break any devices, but whether to check for device or > BlockDriverState sounds more like a block topic to me...

Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

2013-12-18 Thread Andreas Färber
I had a brief look at this series. Dropping redundant fields certainly sounds good and after the lengthy QOM'ifications of IDE devices we seem to no longer break any devices, but whether to check for device or BlockDriverState sounds more like a block topic to me... Regards, Andreas Am 18.12.2013

Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

2013-12-18 Thread Markus Armbruster
Ping? arm...@redhat.com writes: > From: Markus Armbruster > > Obvious cleanups possible since we no longer have the special case of > a non-qdevified controller. > > v2: > * Dropped PATCH 1/10 ide: Break all non-qdevified controllers > Andreas qdevified them since; thanks! > * Series renamed f

[Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

2013-11-20 Thread armbru
From: Markus Armbruster Obvious cleanups possible since we no longer have the special case of a non-qdevified controller. v2: * Dropped PATCH 1/10 ide: Break all non-qdevified controllers Andreas qdevified them since; thanks! * Series renamed from "Drop code for non-qdevified IDE, and clean up