Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-03-14 Thread Denis V. Lunev
On 03/10/2016 08:40 PM, Paolo Bonzini wrote: On 10/03/2016 18:37, Stefan Hajnoczi wrote: I suggest giving the new NBD command a "type" argument: 0 - SCSI mapped/anchored values according to SCSI Get LBA Status 1 - Dirty/clean, useful for incremental backup and other blocking tracking cases Thi

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-03-10 Thread Paolo Bonzini
On 10/03/2016 18:37, Stefan Hajnoczi wrote: > I suggest giving the new NBD command a "type" argument: > 0 - SCSI mapped/anchored values according to SCSI Get LBA Status > 1 - Dirty/clean, useful for incremental backup and other blocking tracking > cases > > This way we don't impinge on SCSI sem

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-03-10 Thread Stefan Hajnoczi
On Mon, Feb 29, 2016 at 9:42 AM, Paolo Bonzini wrote: > > > On 29/02/2016 09:54, Paolo Bonzini wrote: >> >> >> On 29/02/2016 09:14, Markus Armbruster wrote: >>> I completely agree with you that Get LBA Status cannot just reflect the >>> top layer. But that's not what I meant to propose. Let me t

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Markus Armbruster
Markus Armbruster writes: [...] > Consider a QCOW2 image D (for delta) with a backing file B (for base). > If you open it normally, you see "D over B". Get LBA Status should > certainly claim the "deallocated" state only for blocks that are > allocated neither in D nor B. > > However, you can al

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Fam Zheng
On Mon, 02/29 10:42, Paolo Bonzini wrote: > > > On 29/02/2016 09:54, Paolo Bonzini wrote: > > > > > > On 29/02/2016 09:14, Markus Armbruster wrote: > >> I completely agree with you that Get LBA Status cannot just reflect the > >> top layer. But that's not what I meant to propose. Let me try t

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 09:54, Paolo Bonzini wrote: > > > On 29/02/2016 09:14, Markus Armbruster wrote: >> I completely agree with you that Get LBA Status cannot just reflect the >> top layer. But that's not what I meant to propose. Let me try to >> explain myself more clearly. >> >> Consider a QCOW2 i

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 09:14, Markus Armbruster wrote: > I completely agree with you that Get LBA Status cannot just reflect the > top layer. But that's not what I meant to propose. Let me try to > explain myself more clearly. > > Consider a QCOW2 image D (for delta) with a backing file B (for base). >

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/02/2016 09:51, Markus Armbruster wrote: >>> Is it an abuse to "Get LBA Status" to return dirty information? Because in >>> SCSI >>> the command reports "mapped", "allocated" and "anchored" statuses. Does that >>> mean NBD will use a different status set? >> >> Perh

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-26 Thread Fam Zheng
On Fri, 02/26 23:40, Denis V. Lunev wrote: > On 02/26/2016 10:55 PM, Paolo Bonzini wrote: > > > >On 19/02/2016 09:51, Markus Armbruster wrote: > >>>Is it an abuse to "Get LBA Status" to return dirty information? Because in > >>>SCSI > >>>the command reports "mapped", "allocated" and "anchored" sta

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-26 Thread John Snow
On 02/26/2016 03:03 PM, Paolo Bonzini wrote: > > > On 26/02/2016 20:55, Paolo Bonzini wrote: >> >> >> On 19/02/2016 09:51, Markus Armbruster wrote: Is it an abuse to "Get LBA Status" to return dirty information? Because in SCSI the command reports "mapped", "allocated" and "anch

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-26 Thread Denis V. Lunev
On 02/26/2016 10:55 PM, Paolo Bonzini wrote: On 19/02/2016 09:51, Markus Armbruster wrote: Is it an abuse to "Get LBA Status" to return dirty information? Because in SCSI the command reports "mapped", "allocated" and "anchored" statuses. Does that mean NBD will use a different status set? Perh

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-26 Thread Denis V. Lunev
On 02/26/2016 11:03 PM, Paolo Bonzini wrote: On 26/02/2016 20:55, Paolo Bonzini wrote: On 19/02/2016 09:51, Markus Armbruster wrote: Is it an abuse to "Get LBA Status" to return dirty information? Because in SCSI the command reports "mapped", "allocated" and "anchored" statuses. Does that mea

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-26 Thread Paolo Bonzini
On 26/02/2016 20:55, Paolo Bonzini wrote: > > > On 19/02/2016 09:51, Markus Armbruster wrote: >>> Is it an abuse to "Get LBA Status" to return dirty information? Because in >>> SCSI >>> the command reports "mapped", "allocated" and "anchored" statuses. Does that >>> mean NBD will use a differe

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-26 Thread Paolo Bonzini
On 19/02/2016 09:51, Markus Armbruster wrote: >> Is it an abuse to "Get LBA Status" to return dirty information? Because in >> SCSI >> the command reports "mapped", "allocated" and "anchored" statuses. Does that >> mean NBD will use a different status set? > > Perhaps some conceptual gymnastics

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-24 Thread John Snow
On 02/19/2016 03:51 AM, Markus Armbruster wrote: > Fam Zheng writes: > >> On Thu, 02/18 16:41, Stefan Hajnoczi wrote: >>> On Thu, Feb 18, 2016 at 12:11:14PM +, Daniel P. Berrange wrote: On Wed, Feb 17, 2016 at 08:47:11PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 16.02.2

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-19 Thread Markus Armbruster
Fam Zheng writes: > On Thu, 02/18 16:41, Stefan Hajnoczi wrote: >> On Thu, Feb 18, 2016 at 12:11:14PM +, Daniel P. Berrange wrote: >> > On Wed, Feb 17, 2016 at 08:47:11PM +0300, Vladimir Sementsov-Ogievskiy >> > wrote: >> > > On 16.02.2016 20:09, Stefan Hajnoczi wrote: >> > > >On Wed, Feb 10

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-18 Thread Fam Zheng
On Thu, 02/18 16:41, Stefan Hajnoczi wrote: > On Thu, Feb 18, 2016 at 12:11:14PM +, Daniel P. Berrange wrote: > > On Wed, Feb 17, 2016 at 08:47:11PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > On 16.02.2016 20:09, Stefan Hajnoczi wrote: > > > >On Wed, Feb 10, 2016 at 10:10:04AM +,

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-18 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Tue, Feb 16, 2016 at 08:20:44PM +0300, Denis V. Lunev wrote: >> the idea seems feasible at the first glance. I'll need to check >> the amount of the overhead of this approach. If we'll need >> to perform an additional request for each >> block - the overhead is t

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-18 Thread Stefan Hajnoczi
On Thu, Feb 18, 2016 at 12:11:14PM +, Daniel P. Berrange wrote: > On Wed, Feb 17, 2016 at 08:47:11PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > On 16.02.2016 20:09, Stefan Hajnoczi wrote: > > >On Wed, Feb 10, 2016 at 10:10:04AM +, Stefan Hajnoczi wrote: > > >>On Tue, Feb 09, 2016 at 05:

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-18 Thread Stefan Hajnoczi
On Tue, Feb 16, 2016 at 08:20:44PM +0300, Denis V. Lunev wrote: > the idea seems feasible at the first glance. I'll need to check > the amount of the overhead of this approach. If we'll need > to perform an additional request for each > block - the overhead is too much. Regarding overhead, th

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-18 Thread Daniel P. Berrange
On Wed, Feb 17, 2016 at 08:47:11PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 16.02.2016 20:09, Stefan Hajnoczi wrote: > >On Wed, Feb 10, 2016 at 10:10:04AM +, Stefan Hajnoczi wrote: > >>On Tue, Feb 09, 2016 at 05:41:50PM +0300, Denis V. Lunev wrote: > >>>On 02/09/2016 05:28 PM, Stefan Haj

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-17 Thread Fam Zheng
On Wed, 02/17 20:47, Vladimir Sementsov-Ogievskiy wrote: > What about exporting bitmap as separate nbd entity? Just implement > block driver, which will read from bitmap? If consider only read > access and disabled (or frozen) bitmaps it should be simple enough. Yes, I think this idea also makes s

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-17 Thread Vladimir Sementsov-Ogievskiy
On 16.02.2016 20:09, Stefan Hajnoczi wrote: On Wed, Feb 10, 2016 at 10:10:04AM +, Stefan Hajnoczi wrote: On Tue, Feb 09, 2016 at 05:41:50PM +0300, Denis V. Lunev wrote: On 02/09/2016 05:28 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: On 02/03/

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-16 Thread Denis V. Lunev
On 02/16/2016 08:09 PM, Stefan Hajnoczi wrote: On Wed, Feb 10, 2016 at 10:10:04AM +, Stefan Hajnoczi wrote: On Tue, Feb 09, 2016 at 05:41:50PM +0300, Denis V. Lunev wrote: On 02/09/2016 05:28 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: On 02/

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-16 Thread Vladimir Sementsov-Ogievskiy
On 16.02.2016 20:09, Stefan Hajnoczi wrote: On Wed, Feb 10, 2016 at 10:10:04AM +, Stefan Hajnoczi wrote: On Tue, Feb 09, 2016 at 05:41:50PM +0300, Denis V. Lunev wrote: On 02/09/2016 05:28 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: On 02/03/

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-16 Thread Stefan Hajnoczi
On Wed, Feb 10, 2016 at 10:10:04AM +, Stefan Hajnoczi wrote: > On Tue, Feb 09, 2016 at 05:41:50PM +0300, Denis V. Lunev wrote: > > On 02/09/2016 05:28 PM, Stefan Hajnoczi wrote: > > >On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: > > >>On 02/03/2016 11:14 AM, Fam Zheng wrote: >

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-10 Thread Stefan Hajnoczi
On Tue, Feb 09, 2016 at 05:41:50PM +0300, Denis V. Lunev wrote: > On 02/09/2016 05:28 PM, Stefan Hajnoczi wrote: > >On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: > >>On 02/03/2016 11:14 AM, Fam Zheng wrote: > >>>On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > Hi all

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-10 Thread Denis V. Lunev
On 02/09/2016 10:25 PM, Denis V. Lunev wrote: On 02/09/2016 09:12 PM, John Snow wrote: On 02/09/2016 11:58 AM, Denis V. Lunev wrote: On 02/09/2016 07:49 PM, John Snow wrote: On 02/09/2016 09:37 AM, Denis V. Lunev wrote: On 02/09/2016 05:21 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-09 Thread Denis V. Lunev
On 02/09/2016 09:12 PM, John Snow wrote: On 02/09/2016 11:58 AM, Denis V. Lunev wrote: On 02/09/2016 07:49 PM, John Snow wrote: On 02/09/2016 09:37 AM, Denis V. Lunev wrote: On 02/09/2016 05:21 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: On 02/

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-09 Thread John Snow
On 02/09/2016 11:58 AM, Denis V. Lunev wrote: > On 02/09/2016 07:49 PM, John Snow wrote: >> >> On 02/09/2016 09:37 AM, Denis V. Lunev wrote: >>> On 02/09/2016 05:21 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: > On 02/03/2016 11:14 AM, Fam Zh

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-09 Thread Denis V. Lunev
On 02/09/2016 07:49 PM, John Snow wrote: On 02/09/2016 09:37 AM, Denis V. Lunev wrote: On 02/09/2016 05:21 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: On 02/03/2016 11:14 AM, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wro

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-09 Thread John Snow
On 02/09/2016 09:37 AM, Denis V. Lunev wrote: > On 02/09/2016 05:21 PM, Stefan Hajnoczi wrote: >> On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: >>> On 02/03/2016 11:14 AM, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > Th

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-09 Thread Denis V. Lunev
On 02/09/2016 05:21 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: On 02/03/2016 11:14 AM, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: Hi all. These series which aims to add external backup api. This is needed to allow

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-09 Thread Denis V. Lunev
On 02/09/2016 05:28 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: On 02/03/2016 11:14 AM, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: Hi all. These series which aims to add external backup api. This is needed to allow

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-09 Thread Stefan Hajnoczi
On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: > On 02/03/2016 11:14 AM, Fam Zheng wrote: > >On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > >>Hi all. > >> > >>These series which aims to add external backup api. This is needed to allow > >>backup software use our dirty b

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-09 Thread Stefan Hajnoczi
On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: > On 02/03/2016 11:14 AM, Fam Zheng wrote: > >On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > >>Hi all. > >> > >>These series which aims to add external backup api. This is needed to allow > >>backup software use our dirty b

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-05 Thread Denis V. Lunev
On 02/03/2016 11:14 AM, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: Hi all. These series which aims to add external backup api. This is needed to allow backup software use our dirty bitmaps. Vmware and Parallels Cloud Server have this feature. What is the advanta

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-05 Thread Fam Zheng
On Fri, 02/05 11:28, Denis V. Lunev wrote: > On 02/03/2016 11:14 AM, Fam Zheng wrote: > >On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > >>Hi all. > >> > >>These series which aims to add external backup api. This is needed to allow > >>backup software use our dirty bitmaps. > >> > >>Vmwa

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-03 Thread Vladimir Sementsov-Ogievskiy
On 03.02.2016 14:02, Fam Zheng wrote: On Wed, 02/03 13:57, Vladimir Sementsov-Ogievskiy wrote: On 03.02.2016 11:14, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: Hi all. These series which aims to add external backup api. This is needed to allow backup software use

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-03 Thread Fam Zheng
On Wed, 02/03 13:57, Vladimir Sementsov-Ogievskiy wrote: > On 03.02.2016 11:14, Fam Zheng wrote: > >On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > >>Hi all. > >> > >>These series which aims to add external backup api. This is needed to allow > >>backup software use our dirty bitmaps. >

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-03 Thread Vladimir Sementsov-Ogievskiy
On 03.02.2016 11:14, Fam Zheng wrote: On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: Hi all. These series which aims to add external backup api. This is needed to allow backup software use our dirty bitmaps. Vmware and Parallels Cloud Server have this feature. What is the advantage

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-03 Thread Fam Zheng
On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > These series which aims to add external backup api. This is needed to allow > backup software use our dirty bitmaps. > > Vmware and Parallels Cloud Server have this feature. What is the advantage of this appraoch over "drive-

[Qemu-devel] [PATCH v2 0/6] external backup api

2016-01-30 Thread Vladimir Sementsov-Ogievskiy
Hi all. These series which aims to add external backup api. This is needed to allow backup software use our dirty bitmaps. Vmware and Parallels Cloud Server have this feature. There are three things are done: - add query-block-dirty-bitmap-ranges qmp command - add qmp commands for dirty-bitmap f